Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if no sky texture for dark clouds #2711

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Check if no sky texture for dark clouds #2711

merged 1 commit into from
Dec 19, 2022

Conversation

rpaladin
Copy link
Contributor

Errors were thrown if dark clouds were enabled and no sky texture was passed to the world node. Those errors are now fixed.

ERROR: D:\Blender\Projects\RP\0_Build_Files\Mine\A3D\Code_Testing\build_A3D_Code_Testing\compiled\Shaders\World_World.frag.glsl:71: 'hosekSunDirection' : undeclared identifier
ERROR: D:\Blender\Projects\RP\0_Build_Files\Mine\A3D\Code_Testing\build_A3D_Code_Testing\compiled\Shaders\World_World.frag.glsl:71: 'z' : vector swizzle selection out of range
ERROR: D:\Blender\Projects\RP\0_Build_Files\Mine\A3D\Code_Testing\build_A3D_Code_Testing\compiled\Shaders\World_World.frag.glsl:71: '' : compilation terminated

image

image

@luboslenco luboslenco merged commit ca6929b into armory3d:main Dec 19, 2022
@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Dec 19, 2022
@rpaladin rpaladin deleted the fix-dark-clouds branch December 19, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpaladin @luboslenco @MoritzBrueckner