Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic node: Get Object Collection #2752

Merged
merged 3 commits into from
Jan 7, 2023
Merged

logic node: Get Object Collection #2752

merged 3 commits into from
Jan 7, 2023

Conversation

t3du
Copy link
Contributor

@t3du t3du commented Jan 6, 2023

image

@t3du
Copy link
Contributor Author

t3du commented Jan 7, 2023

the first logic retrieved collections from blender but did not considered collections changes by armory nodes... i updated the logic to be consistent with the other collection nodes.

@luboslenco luboslenco merged commit 7b34cff into armory3d:main Jan 7, 2023
@MoritzBrueckner
Copy link
Collaborator

MoritzBrueckner commented Jan 7, 2023

Shouldn't this node return an array since an object can technically be part of multiple collections?

Also, if I remember correctly, groups only contain references to the top-most objects in the group's hierarchy but not to their children. So you might want to use Scene.isObjectInGroup() here even though it might be a tiny bit slower than your approach.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes. label Jan 7, 2023
@t3du
Copy link
Contributor Author

t3du commented Jan 7, 2023

Well then this at least returns the first appearance. I could explore this further later, thanks for the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants