This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Add option to automatically decide amount of Khamake processes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, definitely! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Kode/khamake#262.
This PR adds an option to the user preferences that lets Khamake choose the number of processes automatically if enabled. It's off by default for now since I can only test it on my rather old 4 core computer where the auto setting defaults to 3 processes and is slightly slower than manually specifying more processes. If more tests are made by other users we can probably enable it by default.
@luboslenco I'm wondering whether it's possible to move parts of the preferences out of the SDK into the armory submodule so that we no longer need all the
hasattr()checks (see armory3d/armory#2596) and we have less "separated" PRs. I'm not yet sure whether Blender allows to split the preferences into multiple files/classes while still saving them with one addon (we still need the SDK path setting to be in armory.py, for example), but if it turns out to be technically possible, what would you think of this?