Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Remove Bone Child function #149

Merged
merged 2 commits into from
Dec 31, 2021
Merged

add Remove Bone Child function #149

merged 2 commits into from
Dec 31, 2021

Conversation

t3du
Copy link
Contributor

@t3du t3du commented Dec 29, 2021

This function is need for this new node:
image

public function removeBoneChild(bone: String, o: Object) {
if (boneChildren != null){
var ar: Array<Object> = boneChildren.get(bone);
if (ar.indexOf(o) != -1) ar.remove(o);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't need to check if o exists in the array, according to the Haxe documentation it seems that this is done already in ar.remove(o): https://api.haxe.org/Array.html#remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! lets erase that then

@luboslenco luboslenco merged commit fb8edd1 into armory3d:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants