Initialize scene's object properties

[lampysprites]

Initialize scene traits after the objects are created, which makes child object lookup when assigning properties succeed. Solution from @MoritzBrueckner.

[luboslenco]

Thanks a lot!

which makes child object lookup when assigning properties succeed

Any example on when this happens? Is that not done via notifyOnInit()?

[lampysprites]

Sorry, I meant the lookup that happens internally, when initializing a property of a scene trait, whose type is Object. When set up like so, the property is null during and after initialization, not Cube:

package arm;

class MyTrait extends iron.Trait {
    @prop var obj:iron.object.MeshObject;

    public function new() {
        super();
        notifyOnInit(() -> trace(obj != null)); // false
        notifyOnUpdate(() -> trace(obj != null)); // false false false ...
    }
}

Currently for scene traits, said lookup happens when Root is the only object in the scene as far as I can tell. It was this line IIRC.

Finding the object by name during onInit and assigning it to the property works as expected.

[MoritzBrueckner]

To give a bit more background, previously the initialization order of a scene was the following:

create scene -> create scene traits -> spawn objects -> create object traits

Because of this, object properties weren't correctly initialized in scene traits, as @ lampysprites wrote.

With this change the new initialization order would look like this:

create scene -> spawn objects -> create scene traits -> create object traits

As a positive side effect we can probably remove the last paragraph in https://github.com/armory3d/armory/wiki/traits#trait-events, since it was only true for scene traits after #80 anyways. Now the onInit callback cannot be called anymore before all objects were created, this of course is also true for objects that are spawned later in the game.

[luboslenco]

Awesome!