Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this PR on behalf of @ QuantumCoderQC who is busy currently, so all credit belongs to him :)
In #164, I fixed the particle positions for scaled volumes but I accidentally broke vertex and face emission with that change. This is fixed now by using the owner's scale and
scalePos
instead of the owner's dimensions for vert and face emissions, since vertex positions are encoded in a cubic space as big asscalePos
. The old code is now exclusively used for volumetric emitters where the positions depend on the dimensions of the emitter.By also dividing the
scaleFactor
by the particle'sscalePos
, another bug is fixed that would result in a slight mispositioning of particles if their origin was not at the center of geometry.