Minor refactoring

[utkarsh2102]

Hi @arnau 👋

Here's my take on doing some minor refactoring and most importantly, getting the CI go green again! 🎉

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

[arnau]

I ran rake and RuboCop seems to be complaining:

Running RuboCop...
Inspecting 32 files
............C...................

Offenses:

lib/iso8601/months.rb:66:5: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for calculation is too high. [7/6]
    def calculation(atom, base) ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

32 files inspected, 1 offense detected
RuboCop failed!

[utkarsh2102]

I ran rake and RuboCop seems to be complaining

What version of RuboCop d'you have?

[arnau]

I ran rake and RuboCop seems to be complaining

What version of RuboCop d'you have?

# cat Gemfile.lock
  38   │     rubocop (0.85.1)
  39   │       parallel (~> 1.10)
  40   │       parser (>= 2.7.0.1)
  41   │       rainbow (>= 2.2.2, < 4.0)
  42   │       regexp_parser (>= 1.7)
  43   │       rexml
  44   │       rubocop-ast (>= 0.0.3)
  45   │       ruby-progressbar (~> 1.7)
  46   │       unicode-display_width (>= 1.4.0, < 2.0)

[utkarsh2102]

Okay, I'll put this in .rubocop.yml so this shouldn't be a blocker.

[arnau]

I use nix to isolate the environment and I had to add rake to it. Would you mind adding it to this PR?

# cat default.nix
let
  pkgs = import <nixpkgs> {};
  tooling = [
    pkgs.exa
    pkgs.xsv
    pkgs.git
    pkgs.ruby_2_7
    pkgs.rubyPackages_2_7.rake
  ];

in
  pkgs.mkShell {
    LANG = "en_GB.UTF-8";
    EDITOR="vim";
    buildInputs = tooling ++ [
    ];

    shellHook = ''
      set -o vi
      local pink='\e[1;35m'
      local yellow='\e[1;33m'
      local blue='\e[1;36m'
      local white='\e[0;37m'
      local reset='\e[0m'

      function git_branch {
        git rev-parse --abbrev-ref HEAD 2>/dev/null
      }

      export PS1="\[$pink\]nix \[$blue\]\W \[$yellow\]\$(git_branch)\[$white\] ∙ \[$reset\]"

      alias ls=exa

      source ${pkgs.git}/share/bash-completion/completions/git
    '';
  }

[arnau]

Although, perhaps rake should be a dependency in the gemspec?

It's there 🤦 but doesn't work for me for some reason.

[utkarsh2102]

Okay, I'm going to experiment with a few changes and commits here. Shall squash the related commits in the end.
And then ping you at the end for a review.

Meanwhile if you've any idea about CI failure because of RubyTargetVersion, let me know 😪😅

[arnau]

If I'm reading it correctly, the problem comes from rainbow:

Error: RuboCop found unsupported Ruby version 2.1 in TargetRubyVersion parameter (in vendor/bundle/ruby/2.7.0/gems/rainbow-3.0.0/.rubocop.yml). 2.1-compatible analysis was dropped after version 0.57

Which is a RuboCop dependency 🤔

[utkarsh2102]

Weehoo, CI is green again!
https://travis-ci.org/github/arnau/ISO8601

The problem was that bundler was cached 😄

[arnau]

What about this https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version ?

AllCops:
  TargetRubyVersion: 2.5.0

[utkarsh2102]

So I am going to finally squash them and it should be ready in the next ~10 minutes.

[utkarsh2102]

@arnau, green and ready from my side! 🎉

[arnau]

Unless you have other things in mind, I'll be releasing v0.13.0 soon.

[utkarsh2102]

Sure, looks good for v0.13.0 🎉

[arnau]

Fantastic! nice work, thanks :)