Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests in CI #223

Merged
merged 3 commits into from Dec 6, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

Fix tests for librdkafka 1.0.0, run integration tests as part of CI

  • Loading branch information
Paweł Niedzielski
Paweł Niedzielski committed Dec 5, 2019
commit 6e04788ed8975ca6992f5c251dc030d51b05b60b
@@ -68,17 +68,19 @@ array_walk($topicNames, function ($topicName) use ($consumer, $queue) {
});

$messages = [];
$receivedTopicEofs = [];

while (true) {
while (count($receivedTopicEofs) < 2) {
$msg = $queue->consume(15000);
if (!$msg) {
This conversation was marked as resolved by Steveb-p

This comment has been minimized.

Copy link
@nick-zh

nick-zh Dec 4, 2019

Collaborator

same here with the eof as above 😃

// Still waiting for messages
continue;
}

if (RD_KAFKA_RESP_ERR__PARTITION_EOF === $msg->err) {
// Reached actual EOF for both partitions
break;
// Reached actual EOF
$receivedTopicEofs[$msg->topic_name] = true;
continue;
}

if (RD_KAFKA_RESP_ERR_NO_ERROR !== $msg->err) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.