fix headers, specify length #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
reviewed
Jan 9, 2020
message.c
Outdated
| add_assoc_stringl(&headers_array, header_name, (const char*)header_value, header_size); | ||
| #else | ||
| add_assoc_stringl(&headers_array, header_name, (const char*)header_value, header_size, 1); | ||
| #endif |
There was a problem hiding this comment.
We could define rdkafka_add_assoc_stringl() in php_rdkafka_priv.h, like we did for rdkafka_add_assoc_string()
|
Thanks |
tony2001
added a commit
to tony2001/php-rdkafka
that referenced
this pull request
Oct 1, 2020
* tag '4.0.3': (127 commits) 4.0.3 fix topic deconstruct for high level (arnaud-lb#333) remove examples from repo (arnaud-lb#341) Cast LOG_DEBUG to string in sample (arnaud-lb#340) Use auto.offset.reset earliest instead of smallest (arnaud-lb#339) fix headers, specify length (arnaud-lb#338) add partition check Update README.md Back to dev 4.0.2 Update .editorconfig Revert "dont set partition to zero if null (arnaud-lb#321)" fix consume mem leak use zend_long for zend_parse_parameters arg Fix [-Wformat-extra-args] fix [-Wunused-variable] fix [-Wformat=] warning Back to dev 4.0.1 Run integration tests in CI (arnaud-lb#223) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334