Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract csv parser without mapping to its own module #510

Closed
arnaudroger opened this issue Apr 11, 2018 · 5 comments
Closed

extract csv parser without mapping to its own module #510

arnaudroger opened this issue Apr 11, 2018 · 5 comments
Milestone
4.0.0

Comments

@arnaudroger
Copy link
Owner

arnaudroger commented Apr 11, 2018 •
edited
Loading

lightning-csv ?
@arnaudroger arnaudroger added this to the 4.0.0 milestone Jun 13, 2018
arnaudroger added a commit that referenced this issue Jun 19, 2018
@arnaudroger
#510 new module with csv parser only
a411d17
@arnaudroger
Copy link
Owner Author

extract csv accelaration to external module as quite heavy

@arnaudroger
Copy link
Owner Author

@slandelle might want to check the last version out, extracted the csv parser into it's own lightning-csv module. should work without the asm dep to reduce its size.
https://search.maven.org/artifact/org.simpleflatmapper/lightning-csv/4.0.0/bundle

76K + sfm-utl 52K

@slandelle
Copy link

@arnaudroger Thanks for pinging.

lightning-csv pulls ow2-asm, is it expected?
Also, why is packaging bundle and not jar?

@arnaudroger
Copy link
Owner Author

arnaudroger commented Aug 17, 2018 •
edited
Loading

1 - yes but you can exclude it it should work without it.
2 - osgi compatibility, always been building them as bundle

@slandelle
Copy link

  1. yes, indeed
  2. oh, right

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@slandelle @arnaudroger