New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract csv parser without mapping to its own module #510

Closed
arnaudroger opened this Issue Apr 11, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@arnaudroger
Owner

arnaudroger commented Apr 11, 2018

lightning-csv ?

@arnaudroger arnaudroger added this to the 4.0.0 milestone Jun 13, 2018

@arnaudroger

This comment has been minimized.

Show comment
Hide comment
@arnaudroger

arnaudroger Jun 19, 2018

Owner

extract csv accelaration to external module as quite heavy

Owner

arnaudroger commented Jun 19, 2018

extract csv accelaration to external module as quite heavy

@arnaudroger arnaudroger closed this Jul 5, 2018

@arnaudroger

This comment has been minimized.

Show comment
Hide comment
@arnaudroger

arnaudroger Aug 14, 2018

Owner

@slandelle might want to check the last version out, extracted the csv parser into it's own lightning-csv module. should work without the asm dep to reduce its size.
https://search.maven.org/artifact/org.simpleflatmapper/lightning-csv/4.0.0/bundle

76K + sfm-utl 52K

Owner

arnaudroger commented Aug 14, 2018

@slandelle might want to check the last version out, extracted the csv parser into it's own lightning-csv module. should work without the asm dep to reduce its size.
https://search.maven.org/artifact/org.simpleflatmapper/lightning-csv/4.0.0/bundle

76K + sfm-utl 52K

@slandelle

This comment has been minimized.

Show comment
Hide comment
@slandelle

slandelle Aug 17, 2018

@arnaudroger Thanks for pinging.

lightning-csv pulls ow2-asm, is it expected?
Also, why is packaging bundle and not jar?

slandelle commented Aug 17, 2018

@arnaudroger Thanks for pinging.

lightning-csv pulls ow2-asm, is it expected?
Also, why is packaging bundle and not jar?

@arnaudroger

This comment has been minimized.

Show comment
Hide comment
@arnaudroger

arnaudroger Aug 17, 2018

Owner

1 - yes but you can exclude it it should work without it.
2 - osgi compatibility, always been building them as bundle

Owner

arnaudroger commented Aug 17, 2018

1 - yes but you can exclude it it should work without it.
2 - osgi compatibility, always been building them as bundle

@slandelle

This comment has been minimized.

Show comment
Hide comment
@slandelle

slandelle Aug 17, 2018

  1. yes, indeed
  2. oh, right

Thanks!

slandelle commented Aug 17, 2018

  1. yes, indeed
  2. oh, right

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment