Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable builder extends #583

Merged
merged 1 commit into from Nov 13, 2018
Merged

Enable builder extends #583

merged 1 commit into from Nov 13, 2018

Conversation

@zenios
Copy link
Contributor

zenios commented Nov 13, 2018

Builder pattern with asm does not pickup methods from parent class

Copy link
Owner

arnaudroger left a comment

Thanks! makes sense, I'll push a build with the change asap.

@arnaudroger arnaudroger merged commit 39c0dc2 into arnaudroger:master Nov 13, 2018
28 of 32 checks passed
28 of 32 checks passed
security/snyk - ow2.asm/ASM_5_1/pom.xml (arnaudroger) Manifest not found
Details
security/snyk - ow2.asm/ASM_6_0/pom.xml (arnaudroger) Manifest not found
Details
LGTM analysis: Java Fetching git commits
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk - pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-converter-joda-time/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-converter-protobuf/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-converter/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-csv/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-datastax/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-etl/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-examples/sfm-jooq/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-jdbc/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-jdbi/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-jdbi3/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-jmh/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-jooq/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-map/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-poi/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-querydsl/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-reflect/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-springjdbc/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-sql2o/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-immutables/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-kotlin/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-lombok/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-osgi/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-proto/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test-sandbox/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-test/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-tuples/pom.xml (arnaudroger) No new issues
Details
security/snyk - sfm-util/pom.xml (arnaudroger) No new issues
Details
@zenios

This comment has been minimized.

Copy link
Contributor Author

zenios commented Nov 13, 2018

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

@arnaudroger

This comment has been minimized.

Copy link
Owner

arnaudroger commented Nov 13, 2018

@zenios

This comment has been minimized.

Copy link
Contributor Author

zenios commented Nov 13, 2018

@arnaudroger

This comment has been minimized.

Copy link
Owner

arnaudroger commented Nov 13, 2018

@zenios

This comment has been minimized.

Copy link
Contributor Author

zenios commented Nov 13, 2018

@arnaudroger

This comment has been minimized.

Copy link
Owner

arnaudroger commented Nov 13, 2018

I don't like it either :) but it works there.

@arnaudroger

This comment has been minimized.

Copy link
Owner

arnaudroger commented Nov 13, 2018

6.0.8 is now available in maven central with change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.