Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page action popup UI when activating/exiting Picture-in-Picture fails #2

Closed
arnellebalane opened this issue Oct 9, 2020 · 1 comment
Closed

Page action popup UI when activating/exiting Picture-in-Picture fails #2

arnellebalane opened this issue Oct 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@arnellebalane
Copy link
Owner

Right now errors in activatePictureInPicture and exitPictureInPicture are just logged to the console. It would be better if we update the popup UI and let the user know that something went wrong.
@arnellebalane arnellebalane added the enhancement New feature or request label Oct 9, 2020
@arnellebalane
Copy link
Owner Author

Closing this since all the functionalities have been moved from the page action into the content scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arnellebalane