Factor out methods for commands in CLI app

The run_app method has become too large and does too much. The detail implementation of the individual commands needs separate functions.
arnemertz · Aug 17, 2021 · 3a72ef9 · 3a72ef9
1 parent 81ce342
commit 3a72ef9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 12 deletions.
diff --git a/src/fix_cli/app.cpp b/src/fix_cli/app.cpp
@@ -52,23 +52,31 @@ auto app::run(const std::vector<std::string_view>& args) -> int {
 
 int app::run_command(std::string const& command, const std::vector<std::string>& argv) {
   if (command == "list"sv) {
-    domain::application_service application_service;
-    auto const count = application_service.list();
-    out << fmt::format("total: {} issues\n", count);
-    return EXIT_SUCCESS;
+    return list();
   }
 
   if (command == "create"sv) {
-    auto const& parsed_args = docopt::docopt_parse(std::string(CREATE_USAGE), argv, false, false, false);
-    auto const& title = parsed_args.at("--title").asString();
-    auto const& description = parsed_args.at("--descr").asString();
-
-    domain::application_service application_service;
-    const auto issue_id = application_service.create(title, description);
-    out << fmt::format("Issue created: {}\n", issue_id);
-    return EXIT_SUCCESS;
+    return create(argv);
   }
 
   out << fmt::format("fix: '{}' is not a fix command. See 'fix --help'.\n", command);
   return EXIT_FAILURE;
 }
+
+int app::list() {
+  domain::application_service application_service;
+  auto const count = application_service.list();
+  out << fmt::format("total: {} issues\n", count);
+  return EXIT_SUCCESS;
+}
+
+int app::create(std::vector<std::string> const& argv) {
+  auto const& parsed_args = docopt::docopt_parse(std::string(CREATE_USAGE), argv, false, false, false);
+  auto const& title = parsed_args.at("--title").asString();
+  auto const& description = parsed_args.at("--descr").asString();
+
+  domain::application_service application_service;
+  const auto issue_id = application_service.create(title, description);
+  this->out << fmt::format("Issue created: {}\n", issue_id);
+  return EXIT_SUCCESS;
+}
diff --git a/src/fix_cli/app.hpp b/src/fix_cli/app.hpp
@@ -17,6 +17,8 @@ class app {
 
 private:
   int run_command(std::string const& command, const std::vector<std::string>& argv);
+  int list();
+  int create(std::vector<std::string> const& argv);
 };
 
 } // namespace fix::cli