implement length checks for title

titles may not be too long nor too short, according to the requirements

Author: arnemertz

src/domain/title.cpp

@@ -2,6 +2,9 @@
 
 using fix::domain::title;
 
-bool title::create(std::string_view) { // NOLINT
-  return false;
+constexpr size_t MIN_LENGTH = 6;
+constexpr size_t MAX_LENGTH = 120;
+
+bool title::create(std::string_view text) {
+  return (text.length() >= MIN_LENGTH) && (text.length() <= MAX_LENGTH);
 }

src/domain/title.hpp

@@ -7,7 +7,7 @@ namespace fix::domain {
 
 class title {
 public:
-  static bool create(std::string_view str);
+  static bool create(std::string_view text);
 };
 
 } // namespace fix::domain

test/fix_cli/.clang-tidy renamed to test/.clang-tidy

@@ -2,16 +2,30 @@
 
 #include "title.hpp"
 
+#include <string>
+
 using fix::domain::title;
+using namespace std::literals;
+
+constexpr size_t MIN_LENGTH = 6;
+constexpr size_t MAX_LENGTH = 120;
 
 TEST_CASE("Titles have restricted length") {
   SECTION("titles may not be empty") {
     CHECK_FALSE(title::create(""));
   }
-
-  SECTION("titles may not be too short") {}
-  SECTION("titles may not be too long") {}
-  SECTION("titles with a length in the allowed range can be created") {}
+  SECTION("titles may not be too short") {
+    CHECK_FALSE(title::create("short"));
+  }
+  SECTION("titles may not be too long") {
+    const auto long_scream = std::string(MAX_LENGTH, 'a') + "h"s;
+    CHECK_FALSE(title::create(long_scream));
+  }
+  SECTION("titles with a length in the allowed range can be created") {
+    const auto valid_string = GENERATE(std::string(MIN_LENGTH, 'n'), std::string(MAX_LENGTH, 'x'), "some title with sufficient length"s);
+    const auto title = title::create(valid_string);
+    CHECK(title);
+  }
 }
 
 TEST_CASE("Titles have a restricted character set") {