Numbered commit labels get turned into commit nodes #7

Closed
aroben opened this Issue Mar 30, 2012 · 0 comments

Projects

None yet

1 participant

@aroben
Owner

Some diagrams contain numbered commit labels. These are getting turned into commit nodes, when they should just appear as labels.

1 2 3
A-B-C
     \6 7 8
      F-G-H
1   2/
D---E

@aroben aroben added a commit that referenced this issue Apr 2, 2012
@aroben Make edge following more strict
When following edges we keep track of what edge characters are allowed
next. These prevents following edges such as:

o--o--o
     /
     \
      o

And fixes a bug where, when trying to find parent nodes for B, we'd
traverse from B to \ to A in situations like this:

A B
 \

The edge-traversing algorithm is now much more data-driven. We use a
hash that describes what to do next for each type of edge character, as
well as what to do at the very start of the search.

This changed the sort order of parent nodes in some situations. We
should probably apply some overall sort to the parent nodes so they
aren't so sensitive to the traversal algorithm.

Fixes #5. Also improves #7 slightly, because there are no longer arrows
pointing from numbered labels to nodes. There are still circles around
the numbered labels though.
b56cebc
@aroben aroben closed this in e450c43 Apr 2, 2012
@aroben aroben added a commit that referenced this issue Apr 2, 2012
@aroben Treat numbers with parent nodes as nodes, not labels
This fixes a regression caused by
e450c43, which was fixing #7.
bac6201
@aroben aroben added a commit that referenced this issue Apr 2, 2012
@aroben Treat numbers that are parents as nodes, not labels
This fixes another regression caused by
e450c43, which was fixing #7.
2c2fe37
@aroben aroben added a commit that referenced this issue Apr 2, 2012
@aroben Treat numbers that are parents as nodes, not labels
We now treat a candidate node as a label if it has no parents and is not
the parent of any other node, regardless of its label.

This fixes another regression caused by
e450c43, which was fixing #7.
afcfcf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment