New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add META.json to distribution #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@paultcochrane

This fixes the currently-shown extra issue on CPANTS as well as resolves bug RT#108114.

Add META.json to distribution
This fixes the currently-shown extra issue on
[CPANTS](http://cpants.cpanauthors.org/dist/Unicode-CaseFold) as well as
resolves bug RT#108114.
@arodland

This comment has been minimized.

Show comment
Hide comment
@arodland

arodland Feb 26, 2017

Owner

Added to PluginBundle::ARODLAND so that all my modules get it, instead of doing it here. I will do a release soonish

Owner

arodland commented Feb 26, 2017

Added to PluginBundle::ARODLAND so that all my modules get it, instead of doing it here. I will do a release soonish

@arodland arodland closed this Feb 26, 2017

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-meta-json branch Feb 26, 2017

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Feb 26, 2017

Ok, good to know. It might be a good idea to hold off on releasing for a bit as I've got a couple of other PRs in the works at present.

Ok, good to know. It might be a good idea to hold off on releasing for a bit as I've got a couple of other PRs in the works at present.

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Feb 26, 2017

Hrm, I just upgraded your plugin bundle so that I have the most recent changes and now dzil test doesn't work anymore:

[DZ] attempt to add Build.PL multiple times; added by: content added by @ARODLAND/ModuleBuildTiny (Dist::Zilla::Plugin::ModuleBuildTiny line 130); content set by ModuleBuildTiny (Dist::Zilla::Plugin::ModuleBuildTiny line 155); content set by ModuleBuild (Dist::Zilla::Plugin::ModuleBuild line 232); content set by ModuleBuild::OptionalXS (Dist::Zilla::Plugin::ModuleBuild::OptionalXS line 33); content added by ModuleBuild::OptionalXS (Dist::Zilla::Plugin::ModuleBuild line 200)

Any idea what's going on there?

I was trying to work out why after the README had been produced by a previous run, that its presence blocked following test (or build) runs (it was necessary to explicitly remove the README before dzil test or dzil build would run again). The problem here seemed to come from the CopyFilesFromBuild plugin:

[@ARODLAND/CopyFilesFromBuild] Cannot copy README from build: file does not exist

... although the error message doesn't match the symptom: the README exists and causes the build to fail. Any idea what might have been causing that?

Hrm, I just upgraded your plugin bundle so that I have the most recent changes and now dzil test doesn't work anymore:

[DZ] attempt to add Build.PL multiple times; added by: content added by @ARODLAND/ModuleBuildTiny (Dist::Zilla::Plugin::ModuleBuildTiny line 130); content set by ModuleBuildTiny (Dist::Zilla::Plugin::ModuleBuildTiny line 155); content set by ModuleBuild (Dist::Zilla::Plugin::ModuleBuild line 232); content set by ModuleBuild::OptionalXS (Dist::Zilla::Plugin::ModuleBuild::OptionalXS line 33); content added by ModuleBuild::OptionalXS (Dist::Zilla::Plugin::ModuleBuild line 200)

Any idea what's going on there?

I was trying to work out why after the README had been produced by a previous run, that its presence blocked following test (or build) runs (it was necessary to explicitly remove the README before dzil test or dzil build would run again). The problem here seemed to come from the CopyFilesFromBuild plugin:

[@ARODLAND/CopyFilesFromBuild] Cannot copy README from build: file does not exist

... although the error message doesn't match the symptom: the README exists and causes the build to fail. Any idea what might have been causing that?

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Feb 26, 2017

My apologies: the ModuleBuild issue I mention above was fixed after merging with your most recent changes. So it seems that issue was just PEBKAC. :-/ Your recent dist.ini update also fixed the README issue, so now everything's working nicely :-)

My apologies: the ModuleBuild issue I mention above was fixed after merging with your most recent changes. So it seems that issue was just PEBKAC. :-/ Your recent dist.ini update also fixed the README issue, so now everything's working nicely :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment