Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Conversion #118

Merged
merged 731 commits into from
Aug 13, 2022
Merged

Scala Conversion #118

merged 731 commits into from
Aug 13, 2022

Conversation

aroelke
Copy link
Owner

@aroelke aroelke commented Oct 25, 2021

Convert from Java to Scala (#114).

Also made the following bug fixes and changes:

  • Update list export to include min and max mana values as well as real mana value
  • Properly compare version number from most specific to least
  • Double-clicking to set card count in the deck can now be properly undone
  • The tag file now properly uses a card's Scryfall ID rather than its Multiverse ID
  • Clicking the "remove tag" (red minus) button in the tag editor globally deletes it instead of just removing it from the selected cards
  • Comparing leaf filters now correctly includes the selection of faces they compare
  • Converting from old ".dek" files is no longer supported
  • More resilience against crashes from errors reading individual cards (greater support for reporting them rather than crashing and declaring the entire inventory unreadable)
  • When the number of warnings generated by loading the inventory is too long, it will be displayed in a scrollable panel to constrain the size of the window
  • More resilience against missing data in the inventory JSON
  • Exceptions being thrown or nothing happening when attempting to sort a table column containing tags, power, toughness, format legality, card number, or loyalty
  • Sorting by type line now keeps cards grouped by first card type listed
  • Fix exception thrown when a badly-formed regex is entered into a text filter with regex mode enabled; it just treats it as an empty string
  • Mana value in filters is changed from "mana value," "min," and "max" to "real" and "effective" mana value:
    • "Real" mana value is the single mana value of the card as defined by the rules, which is used for effects that look at cards off the battlefield or stack, like searching a player's hand, graveyard, or library.
    • "Effective" mana value is the per-face mana value of a card while it's on the stack or battlefield, which is used for effects that, for example, care about the mana values of spells a player casts or permanents a player controls.
  • "Defaults" is not a filter option anymore, but may be restored in some form in the future (Filter By Defaults #128)
  • Adventure cards have the correct mana value (that of the creature face, not the sum) (Adventure Card Mana Value #123)

@aroelke aroelke marked this pull request as draft October 25, 2021 21:26
@aroelke
Copy link
Owner Author

aroelke commented Nov 7, 2021

Changes to Deck:

  • Remove category caches; only categorizations should be stored and the GUI is responsible for caching cards

@aroelke
Copy link
Owner Author

aroelke commented Nov 7, 2021

Changes to Filter:

  • Make immutable

@aroelke
Copy link
Owner Author

aroelke commented Nov 7, 2021

Changes to Category:

  • Rename to Categorization
  • Make immutable
  • includes: +, ++/excludes: -, -- (returns copy of this Categorization with card(s) included/excluded)

@aroelke aroelke changed the base branch from master to dev November 9, 2021 21:30
@aroelke
Copy link
Owner Author

aroelke commented Nov 13, 2021

Changes to Symbol:

  • Single enum with all symbols provides total ordering of all symbols, or possibly define an enum for mana symbols and one for other symbols (either way, all of the generic mana symbols will have to be spelled out this way)
  • Different types of symbols can be traits mixed in

@aroelke aroelke mentioned this pull request Mar 27, 2022
@aroelke aroelke marked this pull request as ready for review August 13, 2022 22:29
@aroelke aroelke merged commit cc487be into dev Aug 13, 2022
@aroelke aroelke deleted the scala-conversion branch August 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant