/nglview

fix clear_representation -> removeAllRepresentations #631

Merged
merged 1 commit into from Jul 10, 2017
+1 −1

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hainm @arose
@hainm
Collaborator

hainm commented Jul 10, 2017

@arose why NGL changed clearRepresentations to removeAllRepresentations?
@hainm hainm fix clear_representation -> removeAllRepresentations

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 93.218%
Details
b62888e
@hainm
Collaborator

hainm commented Jul 10, 2017

NGL is quite popular now, so I think should be more careful about changing its API.

@hainm hainm merged commit d74a8fc into arose:master Jul 10, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.218%
Details

hainm deleted the hainm:removeAllRepresentations branch Jul 10, 2017

@arose
Owner

arose commented Jul 10, 2017

it was the wrong name...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment