Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dark theme for users that prefer it #657

Closed
wants to merge 2 commits into from

Conversation

bennypowers
Copy link

@bennypowers bennypowers commented Jan 17, 2023

This PR causes the dark CSS to load for users who prefer dark mode. Closes #586

@arp242
Copy link
Owner

arp242 commented Jan 17, 2023

It's not very good though. Like I said in the issue, I really need someone to go over it for a bit.

@bennypowers
Copy link
Author

IMO they could be addressed in a future PR

I could take a look at implementing an existing color scheme like catppuccin

@arp242
Copy link
Owner

arp242 commented Jan 17, 2023

IMO they could be addressed in a future PR

But in the meanwhile it'll look like crap for everyone with the system theme set to "dark". Especially since browsers don't have a particularly good way of enabling/disabling this per-site AFAIK it'll be quite jarring I think. That's my concern.

Maybe what we can do instead is add a dark/light switcher in the settings or on the top bar, and not watch for prefers-color-scheme: dark yet (until it's improved). This way people who really want it can easily enable it, but it's not going to be a jarring "wtf is this?!" for everyone else.

@arp242
Copy link
Owner

arp242 commented Jan 17, 2023

There's now an option to switch in the user settings (6a25298); the default is still just "light"; once a proper dark theme is available we can change the default to prefers-color-scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Dark theme
2 participants