Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for latex based on vimtex plugin regex #2

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@perelo
Copy link
Contributor

commented Aug 12, 2019

Hi,

Good idea for this plugin !

I simply ported the regex that vimtex uses for ]]-like mappings. See motion.vim.

note that the lua test file is named a.lua which breaks the tests

perelo added some commits Aug 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #2 into master will increase coverage by 9.75%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   51.11%   60.86%   +9.75%     
==========================================
  Files          17       18       +1     
  Lines          45       46       +1     
==========================================
+ Hits           23       28       +5     
+ Misses         22       18       -4
Impacted Files Coverage Δ
after/ftplugin/tex.vim 0% <0%> (ø)
after/ftplugin/sh.vim 100% <0%> (+100%) ⬆️
after/ftplugin/go.vim 100% <0%> (+100%) ⬆️
after/ftplugin/yaml.vim 100% <0%> (+100%) ⬆️
after/ftplugin/ruby.vim 100% <0%> (+100%) ⬆️
after/ftplugin/sql.vim 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb5d12...0bcb5d9. Read the comment docs.

@@ -0,0 +1,2 @@
" Function/augroup definition

This comment has been minimized.

Copy link
@arp242

arp242 Aug 12, 2019

Owner

Can you update the comment to describe where it jumps to? I'm not very familiar with TeX/LaTeX, but based on vimtex's documentation, something like "Section boundary" should be correct?

It should be a short and the to the point description, and gets used in the generated table in the README (use tbl to generate).

Thanks!

This comment has been minimized.

Copy link
@perelo

perelo Aug 12, 2019

Author Contributor

Right, I missed that part.
More likely "Beginning of a section".
Vimtex tries to define all ][, ]]... mappings for "beginning and end of next/previous section", but in the end it only jumps to \end{documents} if no "end of section" was found.

This comment has been minimized.

Copy link
@arp242

arp242 Aug 12, 2019

Owner

Cheers, thanks!

@arp242

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

note that the lua test file is named a.lua which breaks the tests

Do'h; that was silly. Fixed it in master.

@arp242 arp242 merged commit 3748bc1 into arp242:master Aug 12, 2019

3 checks passed

codecov/patch 100% of diff hit (target 51.11%)
Details
codecov/project 80.43% (+29.32%) compared to 3bb5d12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@perelo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Thanks :)

@perelo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Crap, I forgot to update README.markdown, can you re-open the PR?

@arp242

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

Yeh, I noticed but it's not a problem. I wanted to add Python and PHP anyway (which I just did) and updated the README with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.