Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for HID touch screen #64

Merged
merged 1 commit into from May 13, 2020
Merged

Conversation

ayavilevich
Copy link
Contributor

@ayavilevich ayavilevich commented May 11, 2020

A different implementation of an "absolute mouse" that works with Android devices.
In response to #63

@arpruss , you are welcome to merge this as a whole or just parts to the main library if you want.

@arpruss
Copy link
Owner

arpruss commented May 11, 2020

Would it work any worse if we made the range 0-16383 or 0-4095? That would make it easier to convert data from other sources.

@ayavilevich
Copy link
Contributor Author

ayavilevich commented May 12, 2020

@arpruss I don't know. I believe this descriptor was based on a descriptor of some actual hardware. If you want to send me some alternate bytes I can try them out and see if it still works. I don't have the experience to modify the descriptor myself.

What other sources are you talking about? As far as I see, the range needs to be mapped to the screen resolution of the main display of the host device. Mapping will vary with each different host device.

@arpruss arpruss merged commit 1b1791f into arpruss:master May 13, 2020
@arpruss
Copy link
Owner

arpruss commented May 13, 2020

By sources I mean things like a potentiometer or touch screen device that generate the digitizer data.

I changed the range to 16383, and added an example.

I am not sure dragging works on Windows but it does work on Android.

@ayavilevich
Copy link
Contributor Author

ayavilevich commented May 13, 2020

Ok, got it about external devices like a potentiometer.

Thanks for merging and completing the changes. Glad to contribute to this lib which is useful to me.
Some of the changes you made broke the functionality. I have added a comment in the relevant commit.

@arpruss
Copy link
Owner

arpruss commented May 13, 2020

Sorry about that. I changed the range to 4K, which fits the ADC range of the device well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants