New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARQ-400] Properties of arquillian.xml for embedded Glassfish 3.1 are verified and cleansed before use by Arquillian. #6

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@VineetReynolds
Member

VineetReynolds commented Sep 30, 2011

Properties of arquillian.xml for embedded Glassfish 3.1 will be verified for correctness. The configurationXml property is also converted from a file path to a URI before use by the embedded Glassfish container. Added tests to verify the assumptions in unit tests. A gist of the changes is outlined at https://gist.github.com/1251637

@VineetReynolds

This comment has been minimized.

Show comment
Hide comment
@VineetReynolds

VineetReynolds Sep 30, 2011

Member

I've missed pointing out that this pull request also contains bug fix for ARQ-398 as well. The configurationXml property can be specified as:

<property name="configurationXml">src/test/resources/gfconfigs/configxml/test-domain.xml</property>

without requiring the "file:" protocol in the URL.

Member

VineetReynolds commented Sep 30, 2011

I've missed pointing out that this pull request also contains bug fix for ARQ-398 as well. The configurationXml property can be specified as:

<property name="configurationXml">src/test/resources/gfconfigs/configxml/test-domain.xml</property>

without requiring the "file:" protocol in the URL.

@aslakknutsen

This comment has been minimized.

Show comment
Hide comment
@aslakknutsen

aslakknutsen Oct 20, 2011

Member

rebased / squashed and pushed upstream, 173a556

Member

aslakknutsen commented Oct 20, 2011

rebased / squashed and pushed upstream, 173a556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment