/arquillian-cube

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftests throw CubeControlException: Could not stop hello-openshift #1006

Closed
hemanik opened this Issue Feb 28, 2018 · 0 comments

Comments

Assignees

@hemanik hemanik

Labels
None yet
Projects
None yet
Milestone
  1.15.3
2 participants
@hemanik @dipak-pawar
@hemanik
Contributor

hemanik commented Feb 28, 2018

Issue Overview

When executing HelloPodOpenShiftITCase or HelloPodDeploymentOpenShiftITCase ftest the following exception is thrown.

Exception in thread "Thread-1" org.arquillian.cube.spi.CubeControlException: Could not stop hello-openshift
	at org.arquillian.cube.spi.CubeControlException.failedStop(CubeControlException.java:23)
	at org.arquillian.cube.openshift.impl.model.BuildablePodCube.stop(BuildablePodCube.java:153)
	at org.arquillian.cube.impl.client.ForceStopDockerContainersShutdownHook.lambda$attachShutDownHookForceStopDockerContainers$0(ForceStopDockerContainersShutdownHook.java:17)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:128)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.arquillian.cube.openshift.impl.model.BuildablePodCube.stop(BuildablePodCube.java:142)
	... 2 more
Expected Behaviour

After the session is destroyed the pods should be gracefully stopped and destroyed without any exceptions or errors.

Current Behaviour

CubeControlException: Could not stop hello-openshift is caused due to NPE.

Steps To Reproduce
  1. execute HelloPodOpenShiftITCase or HelloPodDeploymentOpenShiftITCase ftest.

@hemanik hemanik self-assigned this Feb 28, 2018

@hemanik hemanik referenced this issue Feb 28, 2018

Merged

fix(#1006): adds state checks in BuildablePodCube stop and destroy lifecycle events. #1007

@dipak-pawar dipak-pawar closed this in #1007 Mar 7, 2018

dipak-pawar added a commit that referenced this issue Mar 7, 2018

@hemanik @dipak-pawar
fix(#1006): adds state checks in BuildablePodCube stop and destroy li… 
…fecycle events. (#1007)

* fix: adds state checks in BuildablePodCube stop and destroy lifecycle events.

* fix: overrides AnnotationDeploymentScenarioGenerator with registered ExternalDeploymentScenarioGenerator service.

* fix: adds unit tests for the lifecycle events.

* mock required objects to remove dependency of running cluster

* chore: updates comments in tests.

* undo commit f0cd6ff related to overriding service.
18215b9

@dipak-pawar dipak-pawar added this to the 1.15.3 milestone Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment