Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldAllowToConnectToRunningContainers stop containers #110

Closed
lordofthejars opened this issue Feb 20, 2015 · 2 comments
Closed

shouldAllowToConnectToRunningContainers stop containers #110

lordofthejars opened this issue Feb 20, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@lordofthejars
Copy link
Member

shouldAllowToConnectToRunningContainers stop containers if container was not started previously. Current behavior is:

if container is already running then is reused, and not stopped at the end of the test execution.

if container is not running and shouldAllowToConnectToRunningContainers stop containers is true, then a container is started and stopped.

The correct behavior should be that if shouldAllowToConnectToRunningContainers stop containers is true and container is not started, Cube should start one but it should not stop it.

@lordofthejars
Copy link
Member Author

After discussing the issue the expected behaviour will be next:

shouldAllowToConnectToTunningContainers is going to be an enum with three possible values:

  • STARTANDSTOP (default): start/stop all and fail if started. This is how it works when now the parameter is false.
  • STARTORCONNECT: start or connect and stop if we started.
  • STARTORCONNECTANDLEAVE: start and leave started for reuse.

@lordofthejars
Copy link
Member Author

Also shouldAllowToConnectToRunningContainers is renamed to connectionMode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants