New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift: Instantiate templates #467

Closed
jwendell opened this Issue Oct 5, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@jwendell
Collaborator

jwendell commented Oct 5, 2016

Templates are a useful resource in Openshift, and it would be great if cube supported it out of the box.

In the ce-arq project we have created an @Template annotation that is responsible for instantiate (i.e., create all resources defined within a template) before the test execution.

An example of usage can be seen in our ce-testsuite project. Notice that this @template mechanism also does variable substitutions (templates can contain variables, or parameters).

The way we implemented it can be seen here.

So, perhaps makes sense to move this thing from downstream ce-arq to upstream arquillian-cube.

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Oct 5, 2016

Member

Thanks, we will take it over

Member

bartoszmajsak commented Oct 5, 2016

Thanks, we will take it over

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 14, 2016

Collaborator

I'm willing to help here, spent some time understanding the internals of arquillian, arquillian-cube and cube-[k8s,openshift].

Before getting my hands dirty... do you have an opinion on how this could be implemented or you're happy with our approach of having an @Template annotation put before each test class?

Collaborator

jwendell commented Oct 14, 2016

I'm willing to help here, spent some time understanding the internals of arquillian, arquillian-cube and cube-[k8s,openshift].

Before getting my hands dirty... do you have an opinion on how this could be implemented or you're happy with our approach of having an @Template annotation put before each test class?

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Oct 14, 2016

Member

That's cool, I didn't know if you can get involved and you have time. But if you are willing to that's more than awesome :)

I think we start with @Template on the class level. I'm not sure if having any other convention here would be useful from the end-user perspective. I believe what you have came up with is providing you good experience and fulfills the use case :)

Member

bartoszmajsak commented Oct 14, 2016

That's cool, I didn't know if you can get involved and you have time. But if you are willing to that's more than awesome :)

I think we start with @Template on the class level. I'm not sure if having any other convention here would be useful from the end-user perspective. I believe what you have came up with is providing you good experience and fulfills the use case :)

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Oct 14, 2016

Member

So if you are up to hack on I can assign it to you (if you cannot do it yourself)

Member

bartoszmajsak commented Oct 14, 2016

So if you are up to hack on I can assign it to you (if you cannot do it yourself)

@bartoszmajsak bartoszmajsak added this to the 1.0.0.Alpha16 milestone Oct 14, 2016

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 14, 2016

Collaborator

@bartoszmajsak It seems I can't assign myself, feel free to do it.

Collaborator

jwendell commented Oct 14, 2016

@bartoszmajsak It seems I can't assign myself, feel free to do it.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Oct 10, 2017

Member

@jwendell it seems this issue is becoming an important issue to have fixed. My question is do you have time to move this feature from arq-ce to cube? If not if you can give some guidelines we are going to work on this.

Member

lordofthejars commented Oct 10, 2017

@jwendell it seems this issue is becoming an important issue to have fixed. My question is do you have time to move this feature from arq-ce to cube? If not if you can give some guidelines we are going to work on this.

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 11, 2017

Collaborator

I'd be glad to help here. Although I don't have much time, I'll use my spare time to do this. Starting work now.

Collaborator

jwendell commented Oct 11, 2017

I'd be glad to help here. Although I don't have much time, I'll use my spare time to do this. Starting work now.

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Oct 16, 2017

Contributor

Just wanted to highlight that this is more important that the stuff mentioned in #814

Contributor

Ladicek commented Oct 16, 2017

Just wanted to highlight that this is more important that the stuff mentioned in #814

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 17, 2017

Collaborator

So, as I stated in #468 , I don't have much spare time as I thought, so, I'll let @lordofthejars take over this work from me. Here's the WIP, feel free to take it as a start point: https://github.com/jwendell/arquillian-cube/tree/wip-templates

Feel free to unassign me from this issue.

Collaborator

jwendell commented Oct 17, 2017

So, as I stated in #468 , I don't have much spare time as I thought, so, I'll let @lordofthejars take over this work from me. Here's the WIP, feel free to take it as a start point: https://github.com/jwendell/arquillian-cube/tree/wip-templates

Feel free to unassign me from this issue.

@lordofthejars lordofthejars added this to the 1.9.2 milestone Oct 17, 2017

@lordofthejars lordofthejars self-assigned this Oct 17, 2017

@bartoszmajsak bartoszmajsak modified the milestones: 1.9.2, 1.9.3 Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment