New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift: Support the creation of generic resources from a file #468

Closed
jwendell opened this Issue Oct 5, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@jwendell
Collaborator

jwendell commented Oct 5, 2016

In the ce-arq project we have an @OpenShiftResource annotation that reads a JSON file and create the resources specified in it before the test execution.

Does it make sense to move this thing to arquillian-cube?

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Oct 5, 2016

Member

Thanks, we will take it over

Member

bartoszmajsak commented Oct 5, 2016

Thanks, we will take it over

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Oct 16, 2017

Contributor

Just wanted to highlight that this is more important that the stuff mentioned in #814

Contributor

Ladicek commented Oct 16, 2017

Just wanted to highlight that this is more important that the stuff mentioned in #814

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Oct 17, 2017

Member

@jwendell @Ladicek I am going to start working on this

Member

lordofthejars commented Oct 17, 2017

@jwendell @Ladicek I am going to start working on this

@lordofthejars lordofthejars self-assigned this Oct 17, 2017

@lordofthejars lordofthejars added this to the 1.9.2 milestone Oct 17, 2017

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 17, 2017

Collaborator

@lordofthejars I believe this and #467 are tied together in our implementation in ce-arq. I started doing this work, and I was moving both features from ce-arq into arq-cube, i.e., I was going to provide a single PR that fixes both issues.

However I don't have much spare time to do that, progress is slow. As you volunteered to do this work, I suggest you do the same as of me: Copy bits from ce-arq into arq-cube directly. I pushed my work so far, perhaps you can start from there: https://github.com/jwendell/arquillian-cube/tree/wip-templates

So, I'm holding my work on this and will let you provide the PR. I'm happy to test it when it's done. Feel free to ping me if you need any help with stuff from ce-arq (I'm jwendell at IRC).

Thanks.

Collaborator

jwendell commented Oct 17, 2017

@lordofthejars I believe this and #467 are tied together in our implementation in ce-arq. I started doing this work, and I was moving both features from ce-arq into arq-cube, i.e., I was going to provide a single PR that fixes both issues.

However I don't have much spare time to do that, progress is slow. As you volunteered to do this work, I suggest you do the same as of me: Copy bits from ce-arq into arq-cube directly. I pushed my work so far, perhaps you can start from there: https://github.com/jwendell/arquillian-cube/tree/wip-templates

So, I'm holding my work on this and will let you provide the PR. I'm happy to test it when it's done. Feel free to ping me if you need any help with stuff from ce-arq (I'm jwendell at IRC).

Thanks.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Oct 17, 2017

Member

Great, yes I'll start collaborating on your repo. Can I fork right now?

Member

lordofthejars commented Oct 17, 2017

Great, yes I'll start collaborating on your repo. Can I fork right now?

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Oct 17, 2017

Collaborator

Sure.

Collaborator

jwendell commented Oct 17, 2017

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment