New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arquillian Cube OpenShift] Implement resource provider for the OpenShift route #744

Closed
RadekKoubsky opened this Issue Jun 27, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@RadekKoubsky

It would be nice to have a resource provider for the OpenShift routes to inject them into a test class.

An example of such solution:

@RunWith(Arquillian.class)
public class ExampleTest {
    @ArquillianResource
     OpenShiftClient client;

     @ArquillianResource
     Route route;
}

instead of getting a route using the openshift client:

final Route route = this.client.adapt(OpenShiftClient.class)
                .routes()
                .inNamespace(this.session.getNamespace())
                .withName(this.applicationName)
                .get();
@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Jun 29, 2017

Member

Hey @RadekKoubsky. Thanks for suggesting this improvement. Would you be interested in providing PR for that?

If you need some help discussing details of the implementation just ping me or @lordofthejars.

Member

bartoszmajsak commented Jun 29, 2017

Hey @RadekKoubsky. Thanks for suggesting this improvement. Would you be interested in providing PR for that?

If you need some help discussing details of the implementation just ping me or @lordofthejars.

@RadekKoubsky

This comment has been minimized.

Show comment
Hide comment
@RadekKoubsky

RadekKoubsky Jul 10, 2017

@bartoszmajsak Hi, I would love to work on Arquillian Cube. However, I have lot of prioritized items for our target release which is not focused on using Arquillian Cube (that is supposed to be for the future release, 1.1.0.Next in Jira). I will come back to this later on.

@bartoszmajsak Hi, I would love to work on Arquillian Cube. However, I have lot of prioritized items for our target release which is not focused on using Arquillian Cube (that is supposed to be for the future release, 1.1.0.Next in Jira). I will come back to this later on.

@spolti

This comment has been minimized.

Show comment
Hide comment
@spolti

spolti Jul 10, 2017

Contributor

I think we have this option on ce-arq (an extension of arquillian-cube).
Instead to use arquillianResource we use this to obtain the route based on the application name:
@RouteURL("eap-app") private URL url;

https://github.com/jboss-openshift/ce-arq/blob/master/cube/src/main/java/org/jboss/arquillian/ce/cube/RouteURL.java

Contributor

spolti commented Jul 10, 2017

I think we have this option on ce-arq (an extension of arquillian-cube).
Instead to use arquillianResource we use this to obtain the route based on the application name:
@RouteURL("eap-app") private URL url;

https://github.com/jboss-openshift/ce-arq/blob/master/cube/src/main/java/org/jboss/arquillian/ce/cube/RouteURL.java

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Jul 10, 2017

Member
Member

lordofthejars commented Jul 10, 2017

@spolti

This comment has been minimized.

Show comment
Hide comment
@spolti

spolti Jul 11, 2017

Contributor

@lordofthejars I'll try to do that, I just have to finish some some priorities.

Contributor

spolti commented Jul 11, 2017

@lordofthejars I'll try to do that, I just have to finish some some priorities.

@jwendell

This comment has been minimized.

Show comment
Hide comment
@jwendell

jwendell Jul 12, 2017

Collaborator

dupe of #465?

Collaborator

jwendell commented Jul 12, 2017

dupe of #465?

@lordofthejars lordofthejars added this to the 1.7.2 milestone Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment