Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
@RouteURL injection doesn't work when routerHost isn't configured. #802
This is consistent with what documentation says (http://arquillian.org/arquillian-cube/#_enrichers), but it doesn't make any sense. The route is read directly from the OpenShift API, the configured
If I remove the check, build Arquillian Cube myself and use the built snapshot, it works just fine.
Steps To Reproduce
CC @rcernich as original author of
changed the title from
`@RouteURL` injection doesn't work when `routerHost` isn't configured.
@RouteURL injection doesn't work when routerHost isn't configured.
Sep 12, 2017
referenced this issue
Sep 12, 2017
+1. This is only necessary when the routes provided by Openshift cannot be resolved by default (think of addresses like
If the route can be resolved somehow (valid dns, entry in /etc/hosts, etc), then specifying routerHost is not mandatory.
I'll put some comments on the PR.
The names have to be resolved by somebody, which means integration with some DNS service. It's been a while since I've used any of the development packages of OpenShift and I don't know if they now integrate a DNS server for resolving routes directly. Because of that, @RouteURL was implemented in such a way that a user could specify the host IP being used for the router so we could resolve the route names directly. That said, perhaps replacing the error with a log message would work better.