New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests work on Openshift and Kubernetes without changes #815

Closed
nicolaferraro opened this Issue Oct 3, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@nicolaferraro
Contributor

nicolaferraro commented Oct 3, 2017

We were using fabric8-arquillian in quickstarts and now we are switching to Arquillian Cube Kubernetes.
I've managed to migrate one quickstart by just changing the dependencies in the pom.xml file.

However, previously tests were working without changes on both Openshift and Kubernetes, while now:

On Openshift
The project should depend explicitly on arquillian-cube-openshift.
An additional flag must be used (enableImageStreamDetection=true) to ensure that imagestreams are correcly created in the testing project. I've put it in the surefire configuration for simplicity.

On Kubernetes
Need not to depend on arquillian-cube-openshift, but on arquillian-cube-kubernetes. The sole dependency on arquillian-cube-openshift turns on a "openshift mode".
Need not to detect image streams.

It would be better if:

  • arquillian-cube-openshift can detect if we are connected to a standard kubernetes cluster and delegate to arquillian-cube-kubernetes (that is imported transitively) all processing steps.
  • The enableImageStreamDetection flag can be defaulted to true when running on Openshift.

If this is ok, I can work on it.

Also: it is not related to this PR, but since you had problems with failsafe in #743 , I can tell you that surefire works like a charm.

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Oct 5, 2017

Contributor

Ad enableImageStreamDetection, that was changed in 1.9.0 per the discussion in #743 and I'd probably be fine with it defaulting to true. (Ad the Failsafe issues in #743, the only thing I remember is that Cube was enabled in Surefire, which I didn't want, and I solved that by manually excluding Cube from Surefire's test classpath, which I'm comfortable with.)

Contributor

Ladicek commented Oct 5, 2017

Ad enableImageStreamDetection, that was changed in 1.9.0 per the discussion in #743 and I'd probably be fine with it defaulting to true. (Ad the Failsafe issues in #743, the only thing I remember is that Cube was enabled in Surefire, which I didn't want, and I solved that by manually excluding Cube from Surefire's test classpath, which I'm comfortable with.)

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 5, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 5, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 5, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 5, 2017

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Oct 6, 2017

Member

Love this improvement.

Member

lordofthejars commented Oct 6, 2017

Love this improvement.

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 6, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

nicolaferraro added a commit to nicolaferraro/arquillian-cube that referenced this issue Oct 10, 2017

lordofthejars added a commit that referenced this issue Oct 10, 2017

Fix Kubernetes-Openshift compatibility (#817)
* Fixes #815: enable imagestream detection on openshift by default

* Fixes #815: defer choice of configuration url to a later stage

* Fixes #815: respect resource declaration order

* Fixes #815: use resource locator in kubernetes reporter

* Fixes #815: locate additional resources in a later stage

* Fixes #815: missing commit to fix method signature

@lordofthejars lordofthejars added this to the 1.9.1 milestone Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment