New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the @AwaitRoute mechanism probably doesn't deal nicely with self-signed HTTPS certs #837

Closed
Ladicek opened this Issue Nov 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Ladicek
Contributor

Ladicek commented Nov 3, 2017

A few weeks ago, I added a mechanism to await routes injected with @RouteURL. That mechanism is always applied and one can't opt-out, so it should better be reliable. However, I believe it won't deal nicely with self-signed HTTPS certificates, and maybe in some other cases.

I'm now thinking this mechanism should be opt-in; i.e., the @AwaitRoute annotations should be outside of @RouteURL and the route awaiting mechanism should only kick in when the annotation is present.

Obviously I volunteer to investigate if the self-signed HTTPS cert suspicion is real and if yes, send a PR with solution proposed above.

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Nov 3, 2017

Contributor

(On Monday, though. Have a nice weekend! :-) )

Contributor

Ladicek commented Nov 3, 2017

(On Monday, though. Have a nice weekend! :-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment