New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `@Repeatable` annotations in OpenShift annotations #851

Closed
lordofthejars opened this Issue Nov 20, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@lordofthejars
Member

lordofthejars commented Nov 20, 2017

Issue Overview

Some annotations such as @Templates, @OpenShiftResources, ... does not using @repeatable` approach.

Expected Behaviour

Implement annotations with @Repeatable

Current Behaviour

Uses old way (prior to Java8)

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Nov 21, 2017

Contributor

Also the names of the wrapper annotations are inconsistent. I propose that the wrapper annotation should be a simple english plural of the wrapped annotation (e.g. @Template and @Templates).

I'm aware of 2 annotations that violate this:

  • @AddRoleToServiceAccount and @AddRoleToServiceAccountWrapper (can be fixed as part of #854)
  • @Template and @TemplateResources
    • Though this case isn't a simple wrapper, there's another parameter syncInstantiation. I don't quite understand its purpose (CC @alesj @jwendell), but even if we don't make @Template repeatable, we still might want to rename @TemplateResources to @Templates.
Contributor

Ladicek commented Nov 21, 2017

Also the names of the wrapper annotations are inconsistent. I propose that the wrapper annotation should be a simple english plural of the wrapped annotation (e.g. @Template and @Templates).

I'm aware of 2 annotations that violate this:

  • @AddRoleToServiceAccount and @AddRoleToServiceAccountWrapper (can be fixed as part of #854)
  • @Template and @TemplateResources
    • Though this case isn't a simple wrapper, there's another parameter syncInstantiation. I don't quite understand its purpose (CC @alesj @jwendell), but even if we don't make @Template repeatable, we still might want to rename @TemplateResources to @Templates.

lordofthejars added a commit to lordofthejars/arquillian-cube that referenced this issue Nov 27, 2017

lordofthejars added a commit that referenced this issue Nov 27, 2017

fix(#851): Unify names of annotations to be more consistent with plur…
…al (#875)

* fix(#851): Unify names of annotations to be more consistent with plural

* chore: rename annotation as review

@lordofthejars lordofthejars added this to the 1.9.3 milestone Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment