New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study HTTP Client abstractions #853

Closed
lordofthejars opened this Issue Nov 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@lordofthejars
Member

lordofthejars commented Nov 21, 2017

Issue Overview

Currently in OpenShift module we are using two Http client abstractions, HTTPClient
and okhttp. Study if we can use only once in all cases.

(#849 (comment))

Expected Behaviour

Only one Http Client used.

Current Behaviour

HTTPClient from Apache commons and okhttp are used.

@Ladicek

This comment has been minimized.

Show comment
Hide comment
@Ladicek

Ladicek Nov 21, 2017

Contributor

Related: the CE-Arq migration brought in an entire module, openshift/httpclient, that provides yet another HTTP client abstraction (implemented using Apache HTTP Client). IMHO, that module should be removed without replacement.

Contributor

Ladicek commented Nov 21, 2017

Related: the CE-Arq migration brought in an entire module, openshift/httpclient, that provides yet another HTTP client abstraction (implemented using Apache HTTP Client). IMHO, that module should be removed without replacement.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Nov 21, 2017

Member

Yes I have noticed here there are several abstractions, and I have pointed out in #849 (comment) that it could be removed by using kubernetes client.

Member

lordofthejars commented Nov 21, 2017

Yes I have noticed here there are several abstractions, and I have pointed out in #849 (comment) that it could be removed by using kubernetes client.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Nov 27, 2017

Member

After removing code where Apache Http Client is used, now only okhttp client is used in all code.
Http client is required for some extra configuration steps such as Jolokia.

Member

lordofthejars commented Nov 27, 2017

After removing code where Apache Http Client is used, now only okhttp client is used in all code.
Http client is required for some extra configuration steps such as Jolokia.

@lordofthejars lordofthejars added this to the 1.9.3 milestone Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment