New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates an integration between Graphene and OpenShift #895

Closed
lordofthejars opened this Issue Dec 5, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@lordofthejars
Member

lordofthejars commented Dec 5, 2017

Issue Overview

Creates an integration between Graphene and OpenShift so Graphene is configured using route as done in Cube Docker https://github.com/arquillian/arquillian-cube/tree/master/docker/drone

Expected Behaviour

Allow Graphene to be configured using the route definition of cluster

Current Behaviour

Cannot be done and you need to set the hardcode url.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Dec 5, 2017

Member

You need to do something like https://github.com/arquillian/arquillian-cube/blob/master/docker/drone/src/main/java/org/arquillian/cube/docker/graphene/location/DockerCubeCustomizableURLResourceProvider.java finding the default route if there is only one or if more than one allows user to set the name of the route. You can see this routing logic at https://github.com/arquillian/arquillian-cube/pull/893/files#diff-f16dd3d4335fc8fb480f5a01965a67e2R245

Finally, you need to override the current strategy in case of standalone: https://github.com/arquillian/arquillian-cube/blob/master/docker/drone/src/main/java/org/arquillian/cube/docker/drone/CubeDockerDroneExtension.java#L33

And I think that this all you need to override the Graphene location.

Of course, just let's write a ftest to validate that everything works as expected.

Member

lordofthejars commented Dec 5, 2017

You need to do something like https://github.com/arquillian/arquillian-cube/blob/master/docker/drone/src/main/java/org/arquillian/cube/docker/graphene/location/DockerCubeCustomizableURLResourceProvider.java finding the default route if there is only one or if more than one allows user to set the name of the route. You can see this routing logic at https://github.com/arquillian/arquillian-cube/pull/893/files#diff-f16dd3d4335fc8fb480f5a01965a67e2R245

Finally, you need to override the current strategy in case of standalone: https://github.com/arquillian/arquillian-cube/blob/master/docker/drone/src/main/java/org/arquillian/cube/docker/drone/CubeDockerDroneExtension.java#L33

And I think that this all you need to override the Graphene location.

Of course, just let's write a ftest to validate that everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment