Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Template to use resources on classpath #949

Closed
dipak-pawar opened this issue Jan 16, 2018 · 1 comment · Fixed by #956
Closed

Allow Template to use resources on classpath #949

dipak-pawar opened this issue Jan 16, 2018 · 1 comment · Fixed by #956
Assignees
@dipak-pawar
Labels
train/ginger
Milestone
1.14.0

Comments

@dipak-pawar
Copy link
Contributor

dipak-pawar commented Jan 16, 2018 •
edited

Currently we are configuring template as follows:

@Template(url = "https://gist.githubusercontent.com/lordofthejars/8781cacd4000a516695ad6c55b5815b3/raw/5151aeef0f5dd8823e2c581c3b7452f04a76af59/hello-template.yaml",
          parameters = @TemplateParameter(name = "RESPONSE", value = "Hello from Arquillian Template"))

If we have template which is available as test resources on classpath. Cube should be able to use it using like following:

@Template(url = "classpath:hello-template.yaml ", parameters = @TemplateParameter(name = "RESPONSE", value = "Hello from Arquillian Template"))
@lordofthejars
Copy link
Member

Exactly as we are doing with OpenShiftResource. Good catch.

@dipak-pawar dipak-pawar self-assigned this Jan 18, 2018
dipak-pawar added a commit to dipak-pawar/arquillian-cube that referenced this issue Jan 18, 2018
@dipak-pawar
feat(arquillian#949): supporting templates from classpath
17c098d
@dipak-pawar dipak-pawar mentioned this issue Jan 18, 2018
Merged
@lordofthejars lordofthejars added this to the 1.13.1 milestone Jan 18, 2018
lordofthejars pushed a commit that referenced this issue Jan 18, 2018
@dipak-pawar @lordofthejars
feat(#949): supporting templates from classpath (#956)
3f39125
dipak-pawar added a commit to dipak-pawar/arquillian-cube that referenced this issue Jan 18, 2018
@dipak-pawar
fix(arquillian#949): improves cube not to stop container if it's alre…
4dc998d 
…ady destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dipak-pawar dipak-pawar

Labels
train/ginger
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

feat(#949): supporting templates from classpath dipak-pawar/arquillian-cube
3 participants
@bartoszmajsak @lordofthejars @dipak-pawar