Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arquillian.xml properties should be injectable in RouteURL annotation #996

Closed
lordofthejars opened this issue Feb 22, 2018 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@lordofthejars
Copy link
Member

@lordofthejars lordofthejars commented Feb 22, 2018

Issue Overview

Expression resolver should be able to resolve this property defined in arquillian.xml if it's used to inject variable in test like @RouteUrl("{app.name}")

Expected Behaviour

Properties defined in arquillian.xml can be injected as @RouteUrl property

Current Behaviour

Not supported

@bartoszmajsak
Copy link
Member

@bartoszmajsak bartoszmajsak commented Feb 26, 2018

We should look if this functionality of generic key-value config pairs is available in core so we can simply pass it to @RouteUrl provider. If not we should enhance core.

@dipak-pawar dipak-pawar self-assigned this Feb 28, 2018
dipak-pawar added a commit to dipak-pawar/arquillian-cube that referenced this issue Feb 28, 2018
dipak-pawar added a commit that referenced this issue Mar 1, 2018
* feat(#996): inject arquillian.xml properties in @RouteUrl

* doc: add documentation for enricher expression resolver

* change OR to or for docs/enrichers.adoc
@dipak-pawar dipak-pawar added this to the 1.15.3 milestone Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.