Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ARQ-892 Should be able to reference the real disk resources in rebel.xml where applicable #8

Merged
merged 6 commits into from

2 participants

@blabno
Collaborator

No description provided.

@aslakknutsen

The last missing piece here is the wrong linking of renamed Assets.

war.setWebXML("test-web.xml")

The location in the archive is WEB-INF/web.xml, but the Asset references test-web.xml. When mapping the rebel.xml file test-web.xml is used. So no changes to test-web.xml is ever detected, as test-web.xml is not a known metadata file to jrebel or the container.

rebel.xml has no concept of renaming references as far as I can see, so we would need to move the renamed Assets into the tmp folder along side generated Assets, at least until JRebel supports this.

You want to add that to this pullrequest or open anew issue?

@blabno
Collaborator

I'll add that to this pull request.

@aslakknutsen

I'm seeing a few of these?
JRebel-Weld: Mapping with pattern is not supported yet for classpath sources!

@blabno
Collaborator

Sorry, but I don't understand. Could you write more or with other words on that?

@aslakknutsen

sorry,

I see those messages in the console log of the server when jrebel reloads the deployment. Not sure if it's complaining about the rebel.xml or something else.

@blabno
Collaborator

Yes, it's about rebel.xml. Have you got a sample for me to reproduce?

@blabno
Collaborator

Dear @aslakknutsen
I have another PR ready (ARQ-1311) and I'd like to base it against this PR. Could we merge this one?

@blabno blabno merged commit d4413f1 into from
@blabno blabno deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.