New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing deployments #1

Merged
merged 1 commit into from Sep 30, 2014

Conversation

Projects
None yet
3 participants
@ivannov
Contributor

ivannov commented Sep 30, 2014

No description provided.

this.source = source;
}
public void source(Object source) {

This comment has been minimized.

@smiklosovic

smiklosovic Sep 30, 2014

Member

are you sure this method is fine? you have setSource and source method which are doing the same thing ...

@smiklosovic

smiklosovic Sep 30, 2014

Member

are you sure this method is fine? you have setSource and source method which are doing the same thing ...

This comment has been minimized.

@aslakknutsen

aslakknutsen Sep 30, 2014

Member

@smiklosovic It's done to support both setting the field in groovy as a property or a method.

deployment {
   source = X
}

deployment {
   source X
}
@aslakknutsen

aslakknutsen Sep 30, 2014

Member

@smiklosovic It's done to support both setting the field in groovy as a property or a method.

deployment {
   source = X
}

deployment {
   source X
}

This comment has been minimized.

@aslakknutsen

aslakknutsen Sep 30, 2014

Member

We might want to rename/wrap these classes as a DSL layer, just to avoid exposing too much of the very specific DSL methods/trix down through the whole model

@aslakknutsen

aslakknutsen Sep 30, 2014

Member

We might want to rename/wrap these classes as a DSL layer, just to avoid exposing too much of the very specific DSL methods/trix down through the whole model

@aslakknutsen aslakknutsen merged commit eac4e3f into arquillian:master Sep 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment