New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce custom assertj assertions #140

Closed
bartoszmajsak opened this Issue Sep 12, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@bartoszmajsak
Member

bartoszmajsak commented Sep 12, 2017

We have introduced several assertions in the latest PRs [1] [2]. They are however done as static methods. As we are using assertj for all our tests I think it would be great to convert them to custom assertions to have a consistent approach to verifying state but also better expressiveness in the tests.

We should avoid having single CustomAssertions class, instead having a custom assertion per concept (e.g. reports). With former we will quickly end up with big bag of everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment