New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE is thrown is strategy is mispelled #167

Closed
lordofthejars opened this Issue Sep 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@lordofthejars
Member

lordofthejars commented Sep 19, 2017

Issue Overview

NPE is thrown if you set a strategy incorrectly

Expected Behaviour

Throw a meaningful exception instead of NPE.

Current Behaviour

NPE

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Sep 19, 2017

Member

Did you mean this instead of that

Good idea, we could use https://en.wikipedia.org/wiki/Levenshtein_distance to find the closest match.

In addition, we can automatically change to the closest match, like we can do with git
git config help.autocorrect 1, but this can be done as a follow-up task

Member

bartoszmajsak commented Sep 19, 2017

Did you mean this instead of that

Good idea, we could use https://en.wikipedia.org/wiki/Levenshtein_distance to find the closest match.

In addition, we can automatically change to the closest match, like we can do with git
git config help.autocorrect 1, but this can be done as a follow-up task

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Sep 19, 2017

Member

Broke it down to two issues. Follow-up with suggestion #170

Member

bartoszmajsak commented Sep 19, 2017

Broke it down to two issues. Follow-up with suggestion #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment