New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaded extension doesn't work with older versions of Maven #175

Closed
bartoszmajsak opened this Issue Sep 20, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@bartoszmajsak
Member

bartoszmajsak commented Sep 20, 2017

Issue Overview

Following the guide, I copied shaded extension (maven-lifecycle-extension-0.0.1-shaded.jar) into M2_HOME/lib/ext, but when running the build nothing happens (no sign of extension in the logs).

Expected Behaviour

The extension is working after installing it by following the guide.

Current Behaviour

No signs of extension kicking in (nothing in the logs).

Steps To Reproduce
  1. Change Maven to version pre 3.3.x
  2. Download extension from Maven Central
  3. Copy to M2_HOME/lib/ext
  4. Run the build using e.g. mvn clean package -Dsmart.testing=new,changed -Dsmart.testing.mode=selecting
Additional Information
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00)
Maven home: /usr/share/maven/apache-maven-3.2.5
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: /usr/java/jdk1.8.0_144/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.12.9-300.fc26.x86_64", arch: "amd64", family: "unix"
arquillian-core [mvn --version]
@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Sep 20, 2017

Member

So we have to decide, either we treat it as high prio and ship fix soon enough, or we drop the support for now and revise the docs.

Member

bartoszmajsak commented Sep 20, 2017

So we have to decide, either we treat it as high prio and ship fix soon enough, or we drop the support for now and revise the docs.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Sep 21, 2017

Member

I think that the easiest and most used way by users would be to just drop support for versions prior to 3.3.X for now.

Member

lordofthejars commented Sep 21, 2017

I think that the easiest and most used way by users would be to just drop support for versions prior to 3.3.X for now.

@MatousJobanek

This comment has been minimized.

Show comment
Hide comment
@MatousJobanek

MatousJobanek Sep 21, 2017

Contributor

Do you have any idea what could be the problem? It can be just a simple bug, but can be also a little bit more complex. How about time-box it for several hours and if it seems to be more complex, then I would drop support for the older version...

Contributor

MatousJobanek commented Sep 21, 2017

Do you have any idea what could be the problem? It can be just a simple bug, but can be also a little bit more complex. How about time-box it for several hours and if it seems to be more complex, then I would drop support for the older version...

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Sep 21, 2017

Member

My idea for dropping is temporary - we just release 0.0.2 with all the fixes and say that older versions are not supported yet. And then we can timebox to analyze. WDYT?

Member

bartoszmajsak commented Sep 21, 2017

My idea for dropping is temporary - we just release 0.0.2 with all the fixes and say that older versions are not supported yet. And then we can timebox to analyze. WDYT?

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars
Member

lordofthejars commented Sep 21, 2017

👍

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Sep 27, 2017

Member

See how https://github.com/jcgay/maven-profiler supports older version of Maven

Timebox to 1d to figure out the root cause and decide

Member

bartoszmajsak commented Sep 27, 2017

See how https://github.com/jcgay/maven-profiler supports older version of Maven

Timebox to 1d to figure out the root cause and decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment