New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartTestingSoftAssertions is not working as per expectation #226

Closed
dipak-pawar opened this Issue Oct 12, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@dipak-pawar
Contributor

dipak-pawar commented Oct 12, 2017

Issue Overview
Expected Behaviour

Test should fail with all failures as this is SoftAssertions.
Here all failures means we are building core/impl-base. So it's writing effective-pom.xml in following directory:

  • config/api/target/smart-testing
  • config/impl-base/target/smart-testing

screenshot from 2017-10-12 17-46-18

So it should assert all assertions at the end. But it's not doing that.

Current Behaviour

Test is passing.

Steps To Reproduce
  1. Go to this test
  2. Change this line from
softly.assertThat(projectBuilder.getBuiltProject()).allBuiltSubModulesContainEffectivePom(EFFECTIVE_POM);

to

softly.assertThat(projectBuilder.getBuiltProject()).allBuiltSubModulesContainEffectivePom("foo.txt);
  1. Run the test in Intellij or using mvn clean test

Note: Please verify allBuiltSubModulesWithTestExecutionsContainReport case as well for assert softly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment