New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeResolver and ChangeStorage should use correct project directory path #228

Closed
MatousJobanek opened this Issue Oct 12, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@MatousJobanek
Contributor

MatousJobanek commented Oct 12, 2017

Issue Overview

When the SmartTesting API is used, the classes ChangeResolver and ChangeStorage don't reflect the directory set using method in. As a side effect, the strategy affected doesn't work correctly in Che - the SmartTesting API is called from a different directory than the project root is.

Expected Behaviour

When I use SmartTesting().with(....).in("path/to/project").apply... the affected strategy should work.

Current Behaviour

the affected strategy throws an exception as it cannot find git directory.

Steps To Reproduce
  1. Call SmartTesting().with(....).in("path/to/project").apply... from different directory than the project root is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment