New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Resource-like annotation in affected tests. #263

Closed
lordofthejars opened this Issue Nov 21, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@lordofthejars
Member

lordofthejars commented Nov 21, 2017

Issue Overview

Currently affected tests annotations only allows you to set a hard dependency with classes. For example:

@ComponentUnderTest(packages = "org.arquillian.smart.testing.strategies.affected.fakeproject.main.superbiz.*")
public class ZTest {

But would be great to add an annotation to allow specify "configuration" files as well. For example if a test must be run if persistence.xml file is modified or kubernetes.json.

For this reason I purpose to have some annotation for example called @Resource (with also its @Repeatable annotation) where you can set this can of relationship.

For example:

@Resource("src/main/resources/persistence.xml")
public class CarDaoTest {}

So if src/main/resources/persistence.xml" is changed then CarDaoTest is run too.

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Nov 21, 2017

Member

@Resource might be misleading here... because it's a very broad term. How about @WatchFile or something better indicating that change in such a file will trigger a test.

Member

bartoszmajsak commented Nov 21, 2017

@Resource might be misleading here... because it's a very broad term. How about @WatchFile or something better indicating that change in such a file will trigger a test.

@lordofthejars

This comment has been minimized.

Show comment
Hide comment
@lordofthejars

lordofthejars Nov 21, 2017

Member

Sure for this reason I said in the title @Resource-like because as you said it is really bad name.

Member

lordofthejars commented Nov 21, 2017

Sure for this reason I said in the title @Resource-like because as you said it is really bad name.

@lordofthejars lordofthejars self-assigned this Nov 21, 2017

lordofthejars added a commit to lordofthejars/smart-testing that referenced this issue Nov 24, 2017

lordofthejars added a commit to lordofthejars/smart-testing that referenced this issue Dec 11, 2017

lordofthejars added a commit that referenced this issue Dec 14, 2017

@bartoszmajsak bartoszmajsak added this to the 0.0.6 milestone Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment