New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency conflict when same library with different version is in pom already #277

Closed
MatousJobanek opened this Issue Dec 7, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@MatousJobanek
Contributor

MatousJobanek commented Dec 7, 2017

Issue Overview

When the project is using a library such as aether with a different version than in SWR is used, then the build fails with:

Dependency convergence error for org.apache.maven.wagon:wagon-provider-api:1.0 paths to dependency are:
+-org.wildfly:wildfly-parent:12.0.0.Alpha1-SNAPSHOT
  +-org.arquillian.smart.testing:surefire-provider:0.0.6-SNAPSHOT
    +-org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:3.0.0
      +-org.eclipse.aether:aether-transport-wagon:1.0.2.v20150114
        +-org.apache.maven.wagon:wagon-provider-api:1.0
and
+-org.wildfly:wildfly-parent:12.0.0.Alpha1-SNAPSHOT
  +-org.arquillian.smart.testing:surefire-provider:0.0.6-SNAPSHOT
    +-org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:3.0.0
      +-org.apache.maven.wagon:wagon-provider-api:2.10
and
+-org.wildfly:wildfly-parent:12.0.0.Alpha1-SNAPSHOT
  +-org.arquillian.smart.testing:surefire-provider:0.0.6-SNAPSHOT
    +-org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:3.0.0
      +-org.apache.maven.wagon:wagon-file:2.10
        +-org.apache.maven.wagon:wagon-provider-api:2.10
and
+-org.wildfly:wildfly-parent:12.0.0.Alpha1-SNAPSHOT
  +-org.arquillian.smart.testing:surefire-provider:0.0.6-SNAPSHOT
    +-org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:3.0.0
      +-org.apache.maven.wagon:wagon-http-lightweight:2.10
        +-org.apache.maven.wagon:wagon-http-shared:2.10
          +-org.apache.maven.wagon:wagon-provider-api:2.10
and
+-org.wildfly:wildfly-parent:12.0.0.Alpha1-SNAPSHOT
  +-org.arquillian.smart.testing:surefire-provider:0.0.6-SNAPSHOT
    +-org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:3.0.0
      +-org.apache.maven.wagon:wagon-http-lightweight:2.10
        +-org.apache.maven.wagon:wagon-provider-api:2.10
Steps To Reproduce
  1. clone https://github.com/wildfly/wildfly
  2. install ST
  3. run build with some strategy specified

@MatousJobanek MatousJobanek self-assigned this Dec 7, 2017

@MatousJobanek MatousJobanek added this to the 0.0.6 milestone Dec 7, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

@MatousJobanek

This comment has been minimized.

Show comment
Hide comment
@MatousJobanek

MatousJobanek Dec 8, 2017

Contributor

It is necessary to:

  • shade SWR with relocation of all libraries otherwise we will get classloading issue
  • shade provider dependency
  • don't add both dependencies provider and surefire API to the effective pom - add only surefire-provider dep to the surefire deps
Contributor

MatousJobanek commented Dec 8, 2017

It is necessary to:

  • shade SWR with relocation of all libraries otherwise we will get classloading issue
  • shade provider dependency
  • don't add both dependencies provider and surefire API to the effective pom - add only surefire-provider dep to the surefire deps

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

fix(arquillian#277): ST surefire provider is added as shaded fat jar …
…containing

shaded jar of SWR 3.0.1
* the surefire provider dependency is not added to the model as
everything should be contained inside of the shaded fat jar
* the surefire API dep is not added tothe model as well, as the
console logger (the reason why it was there) is called by reflection

MatousJobanek added a commit that referenced this issue Dec 11, 2017

fix(#277): ST surefire provider is added as shaded fat jar containing…
… shaded jar of SWR 3.0.1 (#280)

* the surefire provider dependency is not added to the model as
everything should be contained inside of the shaded fat jar
* the surefire API dep is not added to the model as well, as the
console logger (the reason why it was there) is called by reflection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment