New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When some surefire provider is specified, then the logic should be delegated to this provider #278

Closed
MatousJobanek opened this Issue Dec 7, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@MatousJobanek
Contributor

MatousJobanek commented Dec 7, 2017

Issue Overview

When the project has already some surefire provider specified in the the surefire defendencies, then our implementation of surefire provider should delegate the invocation to this provider.
At the same time, the Maven extension should remove the already specified provider and add our implementations, otherwise, there will be two executions, during the build

Steps To Reproduce
  1. clone https://github.com/wildfly/wildfly
  2. install ST
  3. run build with some strategy specified
  4. then you can see that there are two surefire execution - one for surefire-junit47 provider and one for our smart-testing-surefire-provider
[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ wildfly-naming ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.jboss.as.naming.ServiceBasedNamingStoreTestCase
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.286 sec - in org.jboss.as.naming.ServiceBasedNamingStoreTestCase
Running org.jboss.as.naming.subsystem.NamingSubsystemTestCase
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.405 sec - in org.jboss.as.naming.subsystem.NamingSubsystemTestCase
Running org.jboss.as.naming.InitialContextFactoryTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.jboss.as.naming.InitialContextFactoryTestCase
Running org.jboss.as.naming.InitialContextTestCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec - in org.jboss.as.naming.InitialContextTestCase
Running org.jboss.as.naming.NamingEventCoordinatorTestCase
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in org.jboss.as.naming.NamingEventCoordinatorTestCase
Running org.jboss.as.naming.ObjectFactoryTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.jboss.as.naming.ObjectFactoryTestCase
Running org.jboss.as.naming.WritableServiceBasedNamingStoreTestCase
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 sec - in org.jboss.as.naming.WritableServiceBasedNamingStoreTestCase
Running org.jboss.as.naming.ExternalContextsNavigableSetTestCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.jboss.as.naming.ExternalContextsNavigableSetTestCase
Running org.jboss.as.naming.NamingContextTestCase
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec - in org.jboss.as.naming.NamingContextTestCase
Running org.jboss.as.naming.InMemoryNamingStoreTestCase
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.jboss.as.naming.InMemoryNamingStoreTestCase
Running org.wildfly.naming.java.permission.JndiPermissionTestCase
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.wildfly.naming.java.permission.JndiPermissionTestCase

Results :

Tests run: 82, Failures: 0, Errors: 0, Skipped: 0


-------------------------------------------------------
 T E S T S
-------------------------------------------------------
INFO: Smart Testing Extension - Applied strategies: [failed]
INFO: Smart Testing Extension - Applied usage: [selecting]
DEBUG: Smart Testing Extension - Applied test selections: No tests selected as per the strategy chosen.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

@MatousJobanek MatousJobanek self-assigned this Dec 7, 2017

@MatousJobanek MatousJobanek added this to the 0.0.6 milestone Dec 7, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

fix(arquillian#278): if custom surefire provider is specified then th…
…e logic is

delegated to it and known providers resolution is skipped

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

fix(arquillian#278): if custom surefire provider is specified then th…
…e logic is

delegated to it and known providers resolution is skipped

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

fix(arquillian#278): if custom surefire provider is specified then th…
…e logic is

delegated to it and known providers resolution is skipped

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

fix(arquillian#278): if custom surefire provider is specified then th…
…e logic is

delegated to it and known providers resolution is skipped

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 11, 2017

fix(arquillian#278): if custom surefire provider is specified then th…
…e logic is

delegated to it and known providers resolution is skipped

MatousJobanek added a commit that referenced this issue Dec 12, 2017

fix(#278): introduced delegation to custom providers (#281)
if a custom surefire provider is specified then the logic is delegated to it and known providers resolution is skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment