New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be as less intrusive as possible with the dependencies #279

Closed
MatousJobanek opened this Issue Dec 8, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@MatousJobanek
Contributor

MatousJobanek commented Dec 8, 2017

Issue Overview

Most of the strategy implementations, core and also surefire provider has several transitive dependencies. These transitive deps may cause conflicts, classloading issues or other problems such as failures when transitive dependencies are forbidden (using force plugin).
All dependencies that are added to the pom should be as less intrusive as possible.
Proposed solution:

  • surefire provider & core should be handled by this issue: #277
  • all strategies should be shaded as well
  • when the dependency is added to the effective pom.xml file, an exclusion for all dependencies should be set
  • jar should be minimized
Steps To Reproduce
  1. clone https://github.com/wildfly/wildfly
  2. install ST
  3. run build with some strategy specified

@MatousJobanek MatousJobanek added this to the 0.0.6 milestone Dec 8, 2017

@MatousJobanek MatousJobanek self-assigned this Dec 8, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

MatousJobanek added a commit to MatousJobanek/smart-testing that referenced this issue Dec 8, 2017

@MatousJobanek

This comment has been minimized.

Show comment
Hide comment
@MatousJobanek

MatousJobanek Dec 8, 2017

Contributor

WDYT @lordofthejars @bartoszmajsak , should we set also the relocations for the strategies?

Contributor

MatousJobanek commented Dec 8, 2017

WDYT @lordofthejars @bartoszmajsak , should we set also the relocations for the strategies?

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Dec 11, 2017

Member

WDYT @lordofthejars @bartoszmajsak , should we set also the relocations for the strategies?

For the short-term solution it sounds feasible. Let's also open an issue for reviewing which libraries we really need and what could we potentially just write on our own. As this is a library we have to be very careful about the 3rd party we are bringing in as this might result in more issues like the WildFly one.

Member

bartoszmajsak commented Dec 11, 2017

WDYT @lordofthejars @bartoszmajsak , should we set also the relocations for the strategies?

For the short-term solution it sounds feasible. Let's also open an issue for reviewing which libraries we really need and what could we potentially just write on our own. As this is a library we have to be very careful about the 3rd party we are bringing in as this might result in more issues like the WildFly one.

MatousJobanek added a commit that referenced this issue Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment