New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affected strategy doesn't pick up changes made in the other module #43

Closed
bartoszmajsak opened this Issue Jun 27, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@bartoszmajsak
Member

bartoszmajsak commented Jun 27, 2017

Issue Overview

While running affected strategy on arquillian-core I noticed that not all the changes are leading to the discovery of related tests.

This could be related to the fact that we use FileSystemTestClassDetector only.

Current Behaviour

Code modified in one module is not treated as affecting tests from the other one.

Generally speaking, it is a fair assumption that tests and code under test belong to the same module, but as soon as we cross the boundaries of unit testing this might not hold true anymore.

Expected Behaviour

When changing source in one module, tests which are related to it, but belong to another module, should be detected and run if the whole project is built.

Steps To Reproduce

I created a branch with initial setup for Arquillian Core. From there just edit StupidClass.

Expected behaviour: ConfigurationRegistrarTestCase should be executed, even though it belongs to another module.

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak
Member

bartoszmajsak commented Jul 7, 2017

After #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment