New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorized_users documentation vs code #42

Open
mach327 opened this Issue Sep 2, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@mach327

mach327 commented Sep 2, 2016

The default option
:authorized_users => [] and the code that checks if a user is authorized (when Rexexp, when Array, else) implies that the default option for authorized users is actually an empty list, rather than all authenticated users.

The README still says:

By default, any authenticated user will be able to access the protected routes. Restrict this by setting the authorized_users option.

But, with the default option, an authenticated user will get: User was not found in the authorized users list

In practice, this default-open setting can be enabled by setting :authorized_users => nil in the config.rb file.

@tnt

This comment has been minimized.

Show comment
Hide comment
@tnt

tnt May 8, 2017

I'd consider this a bug. It behaved different in older versions. The default was probably actually nil.

tnt commented May 8, 2017

I'd consider this a bug. It behaved different in older versions. The default was probably actually nil.

@LeonineKing1199

This comment has been minimized.

Show comment
Hide comment
@LeonineKing1199

LeonineKing1199 Nov 30, 2017

Thank you for this issue! I was having trouble as well with following the docs. Manually assigning to nil makes everything work perfectly :)

LeonineKing1199 commented Nov 30, 2017

Thank you for this issue! I was having trouble as well with following the docs. Manually assigning to nil makes everything work perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment