Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching support for cond argument in select; Batching Tests #2243

Merged
merged 2 commits into from Jul 20, 2018

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Jul 17, 2018

Addresses: #2236

Select now supports the following combinations:

 |------------+------------+------------+------------|
 | Out Dim    | Cond Dim   | A Dim      | B Dim      |
 |------------+------------+------------+------------|
 | M          | M          | M          | M          |
 | M, N       | M, N       | M, N       | M, N       |
 | M, N, N    | M, N, N    | M, N, N    | M, N, N    |
 | M, N, N, N | M, N, N, N | M, N, N, N | M, N, N, N |
 | M, N       | M, 1       | M, 1       | M, N       |
 | M, N       | M, 1       | M, N       | M, 1       |
 | M, N       | M, 1       | M, N       | M, N       |
 | M, N       | M, N       | M, 1       | M, N       |
 | M, N       | M, N       | M, N       | M, 1       |
 | M, N       | M, N       | M, 1       | M, 1       |
 |------------+------------+------------+------------|

Added tests for all combinations of batches above.

@umar456 umar456 added this to the v3.6.2 milestone Jul 17, 2018
@9prady9 9prady9 merged commit f4be8ef into arrayfire:master Jul 20, 2018
@9prady9 9prady9 deleted the select branch July 20, 2018 05:53
umar456 added a commit to umar456/arrayfire that referenced this pull request Oct 30, 2018
…ayfire#2243)

* Add batching support for cond argument in select; Batching Tests
* Remove c++11 dependency on select tests

(cherry picked from commit f4be8ef)
umar456 added a commit to umar456/arrayfire that referenced this pull request Nov 2, 2018
…ayfire#2243)

* Add batching support for cond argument in select; Batching Tests
* Remove c++11 dependency on select tests

(cherry picked from commit f4be8ef)
umar456 added a commit to umar456/arrayfire that referenced this pull request Nov 3, 2018
…ayfire#2243)

* Add batching support for cond argument in select; Batching Tests
* Remove c++11 dependency on select tests

(cherry picked from commit f4be8ef)
9prady9 pushed a commit that referenced this pull request Nov 3, 2018
* Add batching support for cond argument in select; Batching Tests
* Remove c++11 dependency on select tests

(cherry picked from commit f4be8ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants