move is_complex to common. Hide Array<T> constructor. #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sparse_{cpu,cuda,opencl} are failing and compilation error(s) on windows. |
umar456
force-pushed
the
complex_create
branch
7 times, most recently
from
db43f3f
to
3d954be
Compare
|
@umar456 I think its outdate because of uintl PR I believe. Can you please rebase of master again. |
|
@umar456 Changes look good, if you can rebase. We will get it in. |
umar456
force-pushed
the
complex_create
branch
from
3d954be
to
7f0298a
Compare
umar456
force-pushed
the
complex_create
branch
from
7f0298a
to
ca59c71
Compare
umar456
force-pushed
the
complex_create
branch
from
ca59c71
to
aedb9e7
Compare
9prady9
approved these changes
Nov 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.